fix(ci): preserve dependency parent layers during review cleanup
creative workspace review checks / verify-deployed-canvas (pull_request) Successful in 1m5s
creative workspace review checks / verify (pull_request) Failing after 26m4s

This commit is contained in:
2026-11-01 16:31:56 +08:00
parent 9e5c5abbdf
commit f4397db869
2 changed files with 4 additions and 3 deletions
+2 -1
View File
@@ -14,5 +14,6 @@ for repository in creative-studio-review creative-wiki-tests creative-wiki-revie
echo "Keeping container-referenced review image: $tag"
continue
fi
docker image rm "$tag"
# Preserve parent layers so unchanged dependency installs stay cached.
docker image rm --no-prune "$tag"
done
+2 -2
View File
@@ -38,11 +38,11 @@ class ReviewCleanupTests(unittest.TestCase):
'DOCKER_CALLS': str(calls), 'REVIEW_SHA': sha, **extra})
return result.returncode, [json.loads(line) for line in calls.read_text().splitlines()] if calls.exists() else []
def test_removes_only_exact_review_tags_without_force(self):
def test_removes_only_exact_review_tags_without_force_and_keeps_parent_cache(self):
code, calls = self.run_cleanup()
self.assertEqual(code, 0)
self.assertEqual([args for args in calls if args[:2] == ['image', 'rm']], [
['image', 'rm', name + ':' + SHA] for name in
['image', 'rm', '--no-prune', name + ':' + SHA] for name in
['creative-studio-review', 'creative-wiki-tests', 'creative-wiki-review']])
self.assertFalse(any('-f' in args or 'prune' in args or 'volume' in args for args in calls))