k
6471e44aac
schemas.py:
- Add paper_mode: bool = False to UserResponse so frontend can distinguish
paper vs live subscribers and skip HL API key requirement accordingly
api/user.py:
- Return paper_mode=bool(sub.paper_mode) in GET /user/{wallet}
- Fix elif-chain bug in settings validation: two independent `if` blocks
instead of elif so both TP and SL ranges are checked when trump_enabled
- Conditional validation: TP/SL required only when trump_enabled=True;
daily_budget_usd optional at all times
- Persist trump_enabled / macro_enabled from PUT /user/{wallet}/settings
services/bot_engine.py:
- Remove daily_budget_usd from required fields check — it is optional
(null = no cap). Previous code silently skipped ALL trades for users
who cleared their daily budget cap.
alembic/versions/025_module_toggles.py:
- Add trump_enabled, macro_enabled columns to subscriptions table
tests/test_production_readiness.py:
- Sync test_open_positions_requires_signed_wallet_read to patch
verify_signed_request_any (the function now used) instead of
verify_signed_request; update expected call kwargs accordingly
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
113 lines
2.5 KiB
Python
113 lines
2.5 KiB
Python
import pytest
|
|
|
|
from app.config import Settings
|
|
from app.api import positions
|
|
|
|
|
|
class _Scalar:
|
|
def __init__(self, value):
|
|
self._value = value
|
|
|
|
def scalar_one_or_none(self):
|
|
return self._value
|
|
|
|
def scalar_one(self):
|
|
return self._value
|
|
|
|
def scalars(self):
|
|
return self
|
|
|
|
def all(self):
|
|
return self._value
|
|
|
|
|
|
class _Request:
|
|
async def json(self):
|
|
return {
|
|
"wallet": "0xabc",
|
|
"timestamp": 123,
|
|
"signature": "0xsig",
|
|
}
|
|
|
|
|
|
class _Trade:
|
|
id = 7
|
|
wallet_address = "0xabc"
|
|
closed_at = None
|
|
hl_order_id = "paper"
|
|
leverage = 3
|
|
asset = "BTC"
|
|
exit_price = 101.5
|
|
pnl_usd = 2.25
|
|
|
|
|
|
class _Sub:
|
|
leverage = 3
|
|
hl_api_key = None
|
|
|
|
|
|
class _Db:
|
|
def __init__(self, responses):
|
|
self._responses = list(responses)
|
|
|
|
async def execute(self, _stmt):
|
|
return _Scalar(self._responses.pop(0))
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_manual_close_returns_close_result(monkeypatch):
|
|
async def fake_close_and_finalize(**_kwargs):
|
|
return None
|
|
|
|
monkeypatch.setattr(positions, "verify_signed_request", lambda **_kwargs: None)
|
|
|
|
from app.services import bot_engine
|
|
|
|
monkeypatch.setattr(bot_engine, "close_and_finalize", fake_close_and_finalize)
|
|
|
|
db = _Db([_Trade(), _Sub(), _Trade()])
|
|
|
|
result = await positions.manual_close(7, _Request(), db)
|
|
|
|
assert result.status == "ok"
|
|
assert result.trade_id == 7
|
|
assert result.exit_price == 101.5
|
|
assert result.pnl_usd == 2.25
|
|
assert result.reason == "manual"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_open_positions_requires_signed_wallet_read(monkeypatch):
|
|
calls = []
|
|
|
|
def fake_verify(**kwargs):
|
|
calls.append(kwargs)
|
|
|
|
# get_open_positions now uses verify_signed_request_any (accepts either
|
|
# view_positions or view_user action), so patch that instead.
|
|
monkeypatch.setattr(positions, "verify_signed_request_any", fake_verify)
|
|
db = _Db([[]])
|
|
|
|
result = await positions.get_open_positions(
|
|
wallet="0xABC",
|
|
ts=123,
|
|
sig="0xsig",
|
|
db=db,
|
|
)
|
|
|
|
assert result.wallet == "0xabc"
|
|
assert calls == [{
|
|
"actions": [positions.ACTION_VIEW_POSITIONS, positions.ACTION_VIEW_USER],
|
|
"wallet": "0xabc",
|
|
"timestamp_ms": 123,
|
|
"signature": "0xsig",
|
|
"body": None,
|
|
"allow_replay": True,
|
|
}]
|
|
|
|
|
|
def test_settings_default_to_production_when_environment_not_explicit():
|
|
settings = Settings(database_url="sqlite+aiosqlite:///./test.db")
|
|
|
|
assert settings.environment == "production"
|