Fix canvas placement and CI browser verification #30

Merged
Zayden-Jung merged 4 commits from codex/canvas-node-placement into main 2026-10-30 19:06:46 +00:00
Collaborator

Public canvas acceptance failed when newly derived upscale and script nodes obscured existing reference nodes and intercepted clicks. Derived nodes now keep the requested position when free and otherwise move below occupied content, preserving existing node positions and reference relationships. Public-server coverage checks node separation, persisted text formatting, expansion/undo and screenshots using real user clicks.

CI investigation confirmed that cancelled run #605 left five disposable containers, three volumes and a network running. Integration now handles interruption and both review and release workflows perform a final cleanup restricted to their own numeric run ID and verified Compose ownership labels. Run #608 successfully removed the confirmed #605 leftovers; production resources and other runs are excluded.

Guidance UI verification previously timed out waiting for a response event although /write returned 200 and rendered the expected editor gate. It now verifies a completed 200 session fixture reply and the rendered account state. Document success, account state and all editor assertions remain, with unchanged timeouts.

Validation:

  • Full ces-control review #610 passed for ab5ea7876b: types, unit checks, builds, smoke, PostgreSQL/S3 integration, Canvas Agent flow, Guidance desktop/mobile publishing, authentication/restart checks and final disposable-stack cleanup.
  • Source-only canvas model regression tests: 8/8. Cleanup guard tests: 5/5, including invalid IDs, foreign labels, inventory failure and repeated cleanup.
  • Shell/JavaScript syntax and complete patch formatting checks passed; main and all four pending commits reviewed.

Limitations: this PR is not merged or deployed. After manual merge, the release must pass public-server canvas interaction and desktop/mobile visual acceptance on http://8.211.154.134:18131/. Existing saved overlaps are not automatically reflowed. The cleanup evidence does not establish resource contention as the sole cause of every previous CI timeout.

Public canvas acceptance failed when newly derived upscale and script nodes obscured existing reference nodes and intercepted clicks. Derived nodes now keep the requested position when free and otherwise move below occupied content, preserving existing node positions and reference relationships. Public-server coverage checks node separation, persisted text formatting, expansion/undo and screenshots using real user clicks. CI investigation confirmed that cancelled run #605 left five disposable containers, three volumes and a network running. Integration now handles interruption and both review and release workflows perform a final cleanup restricted to their own numeric run ID and verified Compose ownership labels. Run #608 successfully removed the confirmed #605 leftovers; production resources and other runs are excluded. Guidance UI verification previously timed out waiting for a response event although /write returned 200 and rendered the expected editor gate. It now verifies a completed 200 session fixture reply and the rendered account state. Document success, account state and all editor assertions remain, with unchanged timeouts. Validation: - Full ces-control review #610 passed for ab5ea7876b9d0eb0d7b56a02daf106fa2d0ccdde: types, unit checks, builds, smoke, PostgreSQL/S3 integration, Canvas Agent flow, Guidance desktop/mobile publishing, authentication/restart checks and final disposable-stack cleanup. - Source-only canvas model regression tests: 8/8. Cleanup guard tests: 5/5, including invalid IDs, foreign labels, inventory failure and repeated cleanup. - Shell/JavaScript syntax and complete patch formatting checks passed; main and all four pending commits reviewed. Limitations: this PR is not merged or deployed. After manual merge, the release must pass public-server canvas interaction and desktop/mobile visual acceptance on http://8.211.154.134:18131/. Existing saved overlaps are not automatically reflowed. The cleanup evidence does not establish resource contention as the sole cause of every previous CI timeout.
codex-bot added 1 commit 2026-10-30 17:24:25 +00:00
Place derived canvas nodes without covering existing content
creative workspace review checks / verify (pull_request) Has been cancelled
2cc6f1f543
codex-bot added 1 commit 2026-10-30 17:52:49 +00:00
Verify canvas text formatting and expansion on the deployed server
creative workspace review checks / verify (pull_request) Failing after 13m57s
40c1023a86
codex-bot added 1 commit 2026-10-30 18:14:46 +00:00
Clean disposable CI stacks on interruption and job completion
creative workspace review checks / verify (pull_request) Failing after 7m18s
a589f51698
codex-bot changed title from WIP: Prevent derived canvas nodes from obscuring references to WIP: Fix derived canvas placement and cancelled CI stack cleanup 2026-10-30 18:15:23 +00:00
codex-bot added 1 commit 2026-10-30 18:24:33 +00:00
Synchronize guidance navigation with fulfilled session and rendered state
creative workspace review checks / verify (pull_request) Successful in 23m45s
ab5ea7876b
codex-bot changed title from WIP: Fix derived canvas placement and cancelled CI stack cleanup to Fix canvas placement and CI browser verification 2026-10-30 18:49:31 +00:00
Zayden-Jung merged commit 0849268232 into main 2026-10-30 19:06:46 +00:00
Sign in to join this conversation.
No Reviewers
No Label
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Zayden-Jung/probably-rendering-one-more-pixel-tonight#30