Restructures the textbook pipeline around the distinction the body-derived
dataset had been blurring: a bench should be actual unsolved problems, and
a reusable premise library should only ever contain statements that have
really been proven, the way Mathlib itself works.
- library_candidates/goodman-1.6.jsonl (renamed from datasets/goodman-1.6.jsonl):
the book's own Theorem/Proposition/Lemma/Corollary claims from the main
text. Not bench targets -- premises waiting to be proven once via a real
lean-bench run, then assembled into the reusable library by
build_library.py (which already only keeps success:true entries with
their checked proof, unchanged by this commit).
- datasets/goodman-1.6-exercises.jsonl (new): the actual bench, sourced
from the book's Exercises 1.6 block via two new scripts,
textbook/extract_exercises.py (slices the Exercises block, lists its
numbered items, drops a known false-positive class where a wrapped
cross-reference like "...Proposition\n1.6.19." looks like a real
exercise heading) and textbook/formalize_exercises.py (LLM step, given
both the exercises and body text together since many exercises say
"Prove Proposition N.N.N" instead of restating the claim).
- Both formalize.py and formalize_exercises.py's validate() now enforce
that every checklist item is covered by at least one output entry
(included or explicitly excluded with a reason); formalize_exercises.py
did not have this yet and a first real run silently dropped 7 of 15
checklist items with no trace before this was added.
- All 12 model-produced exercise entries needed real fixes before commit,
the same review pass applied to the body pilot: 3 exercises literally
ask to prove an already-stated body claim (Exercise 1.6.1 -> Proposition
1.6.7, 1.6.2 -> Proposition 1.6.9, 1.6.7 -> Proposition 1.6.18, 1.6.9 ->
Corollary 1.6.20, 1.6.15 -> Lemma 1.6.26) and now reuse that claim's own
already-checked statement verbatim instead of an independently
re-derived (and in one case strictly weaker) restatement; two entries
(1.6.2, 1.6.11) had literal math prose like "I(m, n)" or
"gcd(n1,...,nk)" leaked into the statement field, which is not valid
Lean; several had untyped/ambiguous gcd or Prime usage fixed the same
way the earlier body fixes were (Nat.Prime, IsCoprime, explicit casts,
IsGreatest instead of max on a Set); and Exercise 1.6.12 part (a) turned
out to be a discussion question whose unconditional-identity reading is
actually false (6, 10, 15 are jointly coprime but not pairwise coprime),
so it was moved to the excluded file with a reason instead of committed
as a false theorem.
- Definitions can now be real, compiled Lean, not only JSON metadata:
Definition 1.6.22 (gcd of a list of integers, previously a null
placeholder since no single Mathlib constant matches it) now has a real
hand-written `def IsGCDOfList`, and textbook/build_definitions.py
compiles any manifest's non-null lean_code entries into
lib/Definitions.lean. goodman-1-6-24 (library) and the new
goodman-1-6-ex-11-b/c, goodman-1-6-ex-12 (bench) all now use
IsGCDOfList instead of repeating an inline existential.
- textbook/README.md rewritten around the two-track design and records
how this is meant to connect to lean-agent's eventual goal-directed
proof search against the growing library (not yet built).
- New tests for extract_exercises.py and build_definitions.py; full
local suite still green (18/19, the one failure is the pre-existing,
unrelated lean_agent import error in test_dataset.py).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017vbLFFJiHSZqGZHEkjvG5x
All 21 statements in datasets/goodman-1.6.jsonl now elaborate cleanly
(verified locally via check_statements.py, 11/21 passing before this
change). Fixes applied, one per failing id:
- goodman-1-6-7: single-binder existential-unique over a pair (qr : ZxZ)
instead of the invalid two-binder 'exists unique' form.
- goodman-1-6-10: rewrote set-builder notation to the explicit
{v | exists a b, v = ...} form.
- goodman-1-6-11: replaced 'let d := ... in ...' with the required
semicolon form 'let d := ...; ...', and added the missing Nat-to-Int
casts on d.
- goodman-1-6-17: added explicit Nat-to-Int coercions on the three
divisibility relations.
- goodman-1-6-18: changed p from Z to N (Nat.Prime requires N), added
casts, and replaced the nonexistent Int.Coprime with IsCoprime.
- goodman-1-6-19: changed p from Z to N and added the matching casts.
- goodman-1-6-20: changed p from Z to N, added casts, and fixed the
quantifier structure so the prime-divides-product hypothesis is not
nested inside the per-element forall.
- goodman-1-6-23: replaced the Fin n literal comparison 'j = 0' (which
needs a NeZero instance) with 'j.val = 0'.
- goodman-1-6-24: replaced the invalid bare '(*)' operator section with
'(fun x y => x * y)'-equivalent '(. * .)', and replaced the
nonexistent GCD.gcd with an explicit existential statement of the gcd
property (divides every element; every common divisor divides it).
- goodman-1-6-26: replaced the nonexistent Int.Coprime with IsCoprime.
Also corrected the three parallel hallucinated Mathlib refs in
textbook/goodman-1.6.definitions.json (Int.Coprime, GCD.gcd,
Int.PairwiseCoprime -> IsCoprime, null with notes, and
List.Pairwise IsCoprime respectively), since the Lean compiler confirms
none of the original names exist.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017vbLFFJiHSZqGZHEkjvG5x
Generated with formalize.py against Qwen (qwen-max via DashScope), then hand-fixed
before pushing, since these classes of bug pass elaboration but are still wrong and
check_statements.py can't catch them without running Lean:
- goodman-1-6-2 split into 4 separate theorems (1-6-2-a..d): the model's single
merged statement had an operator-precedence bug (missing parens around an
implicit right-associated AND after OR) that silently scoped 3 of the book's 4
independent claims inside the wrong disjunct.
- goodman-1-6-1: dropped two vacuous "x + y : Nat is a Nat" clauses that confused
Lean's type membership with set membership (element-of Nat on already-Nat-typed
variables) and are automatically true by typing anyway.
- goodman-1-6-9: swapped Mathlib's pointwise Set multiplication (x * I, which needs
'open scoped Pointwise' and is easy to get subtly wrong) for the equivalent
elementwise statement.
- goodman-1-6-13: replaced a misuse of min (a 2-argument function) applied to a Set
with Mathlib's IsLeast predicate, matching what "least element" means in
Int.gcd's characterization.
- goodman-1-6-23: fixed Matrix index types (Fin n, not a bare Nat) and replaced an
illegal literal '...' row with Matrix.vecMul; verified against the book's raw
text that the n-by-n unimodular-matrix formulation is faithful, not a model
invention.
textbook/goodman-1.6.raw.jsonl keeps the unedited model output for reference. The
remaining 13 statements are unedited and still need a real Lean elaboration pass
(check_statements.py) plus a provability run (lean-bench) on a Mathlib-backed
project -- neither ran here since this sandbox has no Lean.
claude-bot
codex-bot