Add versioned board canvas persistence and stable SEO slugs
This commit is contained in:
@@ -14,6 +14,7 @@ import (
|
||||
"net/http/httptest"
|
||||
"os"
|
||||
"regexp"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
_ "github.com/jackc/pgx/v5/stdlib"
|
||||
@@ -154,7 +155,86 @@ func TestOnboardingAndSharing(t *testing.T) {
|
||||
}
|
||||
board := call("POST", workspacePath+"/materials", tokens[0], response{"kind": "board", "title": "Board", "content": response{}}, 201)
|
||||
boardPath := workspacePath + "/materials/" + board["id"].(string)
|
||||
layout := call("POST", boardPath+"/layouts", tokens[0], response{"material_id": articleID, "x": 1, "y": 2, "width": 320, "height": 200, "z_index": 1}, 201, `"1"`)
|
||||
|
||||
canvasPath := boardPath + "/canvas"
|
||||
empty := call("GET", canvasPath, tokens[0], nil, 200)
|
||||
if empty["version"] != float64(1) {
|
||||
t.Fatal("old board not initialized at version 1")
|
||||
}
|
||||
snapshot := response{"document": json.RawMessage(canvasFixture)}
|
||||
call("PATCH", canvasPath, "", snapshot, 401, `"1"`)
|
||||
call("PATCH", canvasPath, tokens[1], snapshot, 403, `"1"`)
|
||||
call("PATCH", canvasPath, tokens[2], snapshot, 404, `"1"`)
|
||||
call("PATCH", canvasPath, tokens[0], snapshot, 428)
|
||||
call("PATCH", canvasPath, tokens[0], snapshot, 200, `"1"`)
|
||||
call("PATCH", canvasPath, tokens[0], snapshot, 412, `"1"`)
|
||||
saved := call("GET", canvasPath, tokens[0], nil, 200)
|
||||
expected, _ := normalizeCanvas(json.RawMessage(canvasFixture))
|
||||
expectedJSON, _ := json.Marshal(json.RawMessage(expected))
|
||||
actualJSON, _ := json.Marshal(saved["document"])
|
||||
if !bytes.Equal(expectedJSON, actualJSON) {
|
||||
t.Fatal("snapshot failed round trip")
|
||||
}
|
||||
call("PATCH", canvasPath, tokens[0], response{"document": response{}}, 400, `"2"`)
|
||||
call("PATCH", boardPath, tokens[0], response{"title": "Renamed", "slug": "my-canvas", "content": response{}}, 204, `"1"`)
|
||||
if call("GET", canvasPath, tokens[0], nil, 200)["version"] != float64(2) {
|
||||
t.Fatal("rename changed canvas version")
|
||||
}
|
||||
slugPath := workspacePath + "/materials/my-canvas"
|
||||
if call("GET", slugPath, tokens[0], nil, 200)["title"] != "Renamed" {
|
||||
t.Fatal("slug lookup failed")
|
||||
}
|
||||
// A PNG at the local upload limit must survive JSON and database storage.
|
||||
var imageDoc map[string]any
|
||||
json.Unmarshal([]byte(canvasFixture), &imageDoc)
|
||||
imageBytes := make([]byte, 2<<20)
|
||||
copy(imageBytes, []byte{137, 80, 78, 71, 13, 10, 26, 10})
|
||||
data := imageDoc["nodes"].([]any)[0].(map[string]any)["data"].(map[string]any)
|
||||
data["kind"] = "image"
|
||||
data["src"] = "data:image/png;base64," + base64.StdEncoding.EncodeToString(imageBytes)
|
||||
call("PATCH", canvasPath, tokens[0], response{"document": imageDoc}, 200, `"2"`)
|
||||
restored := call("GET", canvasPath, tokens[0], nil, 200)
|
||||
if restored["document"].(map[string]any)["nodes"].([]any)[0].(map[string]any)["data"].(map[string]any)["src"] != data["src"] {
|
||||
t.Fatal("large image changed")
|
||||
}
|
||||
call("PATCH", canvasPath, tokens[0], response{"document": strings.Repeat("x", canvasLimit)}, 413, `"3"`)
|
||||
if call("GET", canvasPath, tokens[0], nil, 200)["version"] != float64(3) {
|
||||
t.Fatal("rejected snapshot changed version")
|
||||
}
|
||||
// Restore the material version expected by the pre-existing layout checks below.
|
||||
|
||||
// Exercise two independent HTTP transactions against the same expected version.
|
||||
encodedSnapshot, _ := json.Marshal(snapshot)
|
||||
statuses := make(chan int, 2)
|
||||
start := make(chan struct{})
|
||||
for range 2 {
|
||||
go func() {
|
||||
<-start
|
||||
request := httptest.NewRequest("PATCH", canvasPath, bytes.NewReader(encodedSnapshot))
|
||||
request.Header.Set("Authorization", "Bearer "+tokens[0])
|
||||
request.Header.Set("If-Match", `"3"`)
|
||||
recorder := httptest.NewRecorder()
|
||||
mux.ServeHTTP(recorder, request)
|
||||
statuses <- recorder.Code
|
||||
}()
|
||||
}
|
||||
close(start)
|
||||
one, two := <-statuses, <-statuses
|
||||
if !((one == 200 && two == 412) || (one == 412 && two == 200)) {
|
||||
t.Fatalf("concurrent writes: %d %d", one, two)
|
||||
}
|
||||
if call("GET", boardPath, tokens[0], nil, 200)["title"] != "Renamed" {
|
||||
t.Fatal("canvas save changed title")
|
||||
}
|
||||
call("PATCH", workspacePath, tokens[0], response{"name": "Team", "slug": "research-team"}, 204)
|
||||
call("GET", base+"/workspaces/research-team/materials/my-canvas/canvas", tokens[0], nil, 200)
|
||||
call("PATCH", workspacePath, tokens[1], response{"name": "Team", "slug": "stolen"}, 403)
|
||||
call("POST", base+"/workspaces", tokens[0], response{"name": "Duplicate", "slug": "research-team"}, 409)
|
||||
call("PATCH", workspacePath, tokens[0], response{"name": "Renamed Team"}, 204)
|
||||
if call("GET", workspacePath, tokens[0], nil, 200)["slug"] != "research-team" {
|
||||
t.Fatal("rename changed slug")
|
||||
}
|
||||
layout := call("POST", boardPath+"/layouts", tokens[0], response{"material_id": articleID, "x": 1, "y": 2, "width": 320, "height": 200, "z_index": 1}, 201, `"2"`)
|
||||
call("GET", boardPath+"/layouts", tokens[1], nil, 200)
|
||||
call("POST", boardPath+"/grants", tokens[0], response{"account_id": accounts[2], "role": "viewer"}, 204)
|
||||
hidden := call("GET", boardPath+"/layouts", tokens[2], nil, 200)
|
||||
@@ -162,7 +242,7 @@ func TestOnboardingAndSharing(t *testing.T) {
|
||||
t.Fatal("board share disclosed private child material")
|
||||
}
|
||||
call("DELETE", boardPath+"/layouts/"+layout["id"].(string), tokens[0], nil, 412, `"1"`)
|
||||
call("DELETE", boardPath+"/layouts/"+layout["id"].(string), tokens[0], nil, 204, `"2"`)
|
||||
call("DELETE", boardPath+"/layouts/"+layout["id"].(string), tokens[0], nil, 204, `"3"`)
|
||||
call("DELETE", textPath+"/grants/"+accounts[2], tokens[0], nil, 204)
|
||||
call("GET", textPath, tokens[2], nil, 404)
|
||||
call("DELETE", workspacePath+"/tags/"+tag["id"].(string), tokens[0], nil, 204)
|
||||
|
||||
Reference in New Issue
Block a user