From 155ce28c3705b50c6855715f63df1d53f1e72e08 Mon Sep 17 00:00:00 2001 From: Codex Bot Date: Thu, 5 Nov 2026 20:22:51 +0800 Subject: [PATCH] Report inconclusive Slack placeholder-code checks accurately --- .gitea/workflows/check.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.gitea/workflows/check.yml b/.gitea/workflows/check.yml index 7c005a3..f3ad8e9 100644 --- a/.gitea/workflows/check.yml +++ b/.gitea/workflows/check.yml @@ -17,7 +17,7 @@ jobs: test -z "$(gofmt -l cmd internal)" go test -mod=readonly ./... go build -mod=readonly -o bin/foundry ./cmd/foundry - - name: Verify configured Slack client credentials + - name: Check Slack OAuth configuration and endpoint if: gitea.event_name == 'push' env: SLACK_CLIENT_ID: ${{ secrets.SLACK_CLIENT_ID }} @@ -57,6 +57,10 @@ jobs: if actual in ("invalid_code", "invalid_grant") and control in ("bad_client_secret", "invalid_client"): print("Slack client credentials accepted; invalid-secret negative control rejected") print("A real user authorization is still required to verify the complete login") + elif actual in ("invalid_code", "invalid_grant") and control in ("invalid_code", "invalid_grant"): + print("Both Slack Actions secrets are available and the OAuth endpoint is reachable") + print("Slack rejected the placeholder code before validating the client secret") + print("Client-secret validity requires a real user authorization; this is not a complete login test") else: known = {"invalid_client_id", "bad_client_secret", "invalid_client", "invalid_code", "invalid_grant", "bad_redirect_uri", "accesslimited", "ratelimited"}