perf: retain precise name observations in property binding caches
This commit is contained in:
+13
-7
@@ -233,6 +233,7 @@ struct Session {
|
||||
layout_cancels: usize,
|
||||
paint_cancels: usize,
|
||||
paint_slices: usize,
|
||||
binding_evaluations: usize,
|
||||
exiting: bool,
|
||||
}
|
||||
|
||||
@@ -1176,6 +1177,7 @@ impl NativeCallable for Function {
|
||||
("layoutCancels", session.layout_cancels as i64),
|
||||
("paintCancels", session.paint_cancels as i64),
|
||||
("paintSlices", session.paint_slices as i64),
|
||||
("bindingEvaluations", session.binding_evaluations as i64),
|
||||
(
|
||||
"dependencyInvalidations",
|
||||
session.dependency_invalidations as i64,
|
||||
@@ -2471,13 +2473,16 @@ impl UiBridge {
|
||||
Ok(())
|
||||
}
|
||||
pub fn refresh_bindings(&self, vm: &mut Vm) -> Result<()> {
|
||||
let nodes = self
|
||||
.session
|
||||
.lock()
|
||||
.map_err(|_| anyhow::anyhow!("UI session poisoned"))?
|
||||
.nodes
|
||||
.clone();
|
||||
crate::binding::refresh(vm, &nodes)
|
||||
let (nodes, desktops) = {
|
||||
let state = self.session.lock()
|
||||
.map_err(|_| anyhow::anyhow!("UI session poisoned"))?;
|
||||
(state.nodes.clone(), state.host_desktops())
|
||||
};
|
||||
let evaluated = crate::binding::refresh(vm, &nodes, &desktops)?;
|
||||
let mut state = self.session.lock()
|
||||
.map_err(|_| anyhow::anyhow!("UI session poisoned"))?;
|
||||
state.binding_evaluations = state.binding_evaluations.saturating_add(evaluated);
|
||||
Ok(())
|
||||
}
|
||||
pub fn prepare_frame(&self, vm: &mut Vm) -> Result<Option<Option<Arc<UiNode>>>> {
|
||||
let changes = vm.take_changes();
|
||||
@@ -3018,6 +3023,7 @@ pub fn install(vm: &mut Vm, roots: &mut Vec<ObjectRef>) -> Result<UiBridge> {
|
||||
layout_cancels: 0,
|
||||
paint_cancels: 0,
|
||||
paint_slices: 0,
|
||||
binding_evaluations: 0,
|
||||
exiting: false,
|
||||
}));
|
||||
let mut public_functions = Vec::new();
|
||||
|
||||
Reference in New Issue
Block a user