fix: restore comfortable tab height with native control alignment
Verify Tessera GUI / verify (push) Failing after 1m39s

This commit is contained in:
2026-10-25 15:01:32 +08:00
parent 846c99a991
commit 7b769b1477
8 changed files with 125 additions and 14 deletions
+36 -5
View File
@@ -4,9 +4,9 @@ This audit follows the full conversation, including later corrections. Implement
| Requirement | Implementation | Evidence / limits |
| --- | --- | --- |
| One top row with native macOS controls | Transparent/full-size native title bar; reserved control space; 28 px tab strip centered with AppKit traffic lights | Actual Retina macOS windows viewed; native close/minimize/fullscreen controls retained |
| One top row with native macOS controls | Transparent/full-size native title bar; reserved control space; 40 px tab strip; native AppKit controls repositioned to its y=20 center | Actual Retina macOS windows viewed; native close/minimize/fullscreen controls retained |
| Continuous left/top chrome | One neutral background; 56 px left rail; inset content panel | Actual main and detached windows viewed; no Tools label or rail launchers |
| Compact symmetric round tabs, softer active state | 88–208 px width; 24 px pill with equal 2 px vertical insets; 13 px labels and matching 18 px icon/close slots; no hard active stroke | Native settled UI viewed; hover and selected use the same bounds |
| Compact symmetric round tabs, softer active state | 88–208 px width; 32 px pill with equal 4 px vertical insets; 13 px labels and matching 18 px icon/close slots; no hard active stroke | Native settled UI viewed; hover and selected use the same bounds |
| + and startup default page | One startup request guarded against duplicate resume; + release-inside; Cmd/Ctrl+T | Immediately after restart: pages().count = 1. Two native Cmd+T actions produced three tabs |
| New-tab motion, filled and unfilled | 220 ms cubic ease; insertion grows from the previous trailing edge; full-strip geometry and + interpolate; removed tabs shrink without remaining interactive | Real native new/close/fill operations completed; settled compression/overflow viewed. No frame-by-frame recording or Chrome timing comparison |
| Overflow and scrolling | Separate + reservation; no arrow buttons; logical-pixel wheel/trackpad scrolling and clipped offscreen tabs; invisible drag edge dwell retained | Native overflow reached; + in overflow increased VM count 7 → 8. Dragging out of + kept count at 7 |
@@ -130,9 +130,9 @@ scrolling follows input directly, while insertion, closure and automatic reveal
use the 220 ms transition. OS momentum remains ordinary subsequent wheel input.
No touchscreen hardware verification is claimed.
The 28 px row centers tabs at y=14, matching the retained AppKit controls in the
native macOS window. Pills are 24 px high, with 2 px top/bottom margins and 13 px
labels. A 1 × 12 px divider separates adjacent inactive tabs; it is hidden beside
The initial 28 px row was too shallow. The revised 40 px row centers tabs at
y=20 and repositions the retained native AppKit controls onto the same center
line. Pills are 32 px high, with 4 px top/bottom margins and 13 px labels. A 1 × 12 px divider separates adjacent inactive tabs; it is hidden beside
an active or hovered tab. Hover and selection retain the same pill geometry.
Manual native checks covered startup, + and repeated Cmd+T, dense overflow,
@@ -146,3 +146,34 @@ Formatting, all-target offline Clippy with warnings denied, release app bundling
and whitespace checks passed. Existing geometry test fixtures were updated for
pixel offsets and the denser layout; they were type-checked by Clippy but no
cargo test, automated smoke script or Docker task was run.
### Comfortable row height with native alignment — 2026-10-25
The current Chromium [layout constants](https://github.com/chromium/chromium/blob/main/chrome/browser/ui/layout_constants.cc)
define a 35 px tab (34 + 1 px toolbar overlap) and 6 px strip padding, totaling
41 px. Tessera uses a 40 px row with a symmetric 32 px capsule, retaining its
88–208 px width range, separators, gesture scrolling and insertion motion.
Only the in-app web view is available for agent-owned browser access, so this
is a source/reference-image comparison, not a live measurement of Chrome.
A macOS-only adapter obtains the winit-owned content NSView and positions the
three real standard window buttons at the row's center. It preserves their
native sizes, horizontal positions and actions, and reapplies alignment before
drawing after native layout changes. Fullscreen floating controls stay under
AppKit management. Native bindings were already cached transitively; direct
macOS-only dependencies now declare this use explicitly.
Manual resizing followed by repeated tab creation exposed a renderer panic:
rounding at large absolute x positions could invert a rounded rectangle's
clamp bounds while a tab grew from almost zero width. Rounded hit coverage now
clamps in local coordinates with a radius bounded by half the rectangle size.
Final native checks passed for 18 consecutive Cmd+T insertions, dense overflow,
wheel scrolling, five consecutive Cmd+W closures and native window zoom. The
final process stayed running without stderr errors. Initial native screenshots
showed the traffic lights, tab capsules and + centered at the same y position.
Subsequent computer-control captures can display macOS's capture badge over the
traffic lights. Fullscreen floating controls and mixed-DPI moves were not tested.
Offline all-target Clippy with warnings denied, formatting, release app bundling
and git whitespace checks passed; no cargo test or automated smoke script ran.