perf: validate precise source name dependencies before relayout and repaint
This commit is contained in:
+9
-10
@@ -2596,17 +2596,13 @@ impl UiBridge {
|
||||
progress: crate::source_paint::Progress,
|
||||
) -> Result<crate::source_paint::Progress> {
|
||||
if let crate::source_paint::Progress::Complete(draft) = &progress {
|
||||
let reads = draft
|
||||
.reads
|
||||
.iter()
|
||||
.copied()
|
||||
.map(|object| vm.change_version(object).map(|version| (object, version)))
|
||||
.collect::<Result<std::collections::BTreeMap<_, _>, _>>()?;
|
||||
let (reads, names) = crate::presentation::split_reads(draft.reads.clone());
|
||||
let mut state = self
|
||||
.session
|
||||
.lock()
|
||||
.map_err(|_| anyhow::anyhow!("UI session poisoned"))?;
|
||||
state.paint_reads = reads;
|
||||
state.paint_names = names;
|
||||
state.paint_slices = draft.slices;
|
||||
}
|
||||
Ok(progress)
|
||||
@@ -2650,6 +2646,11 @@ impl UiBridge {
|
||||
.map_err(|_| anyhow::anyhow!("UI session poisoned"))?
|
||||
.layout_reads
|
||||
.clear();
|
||||
self.session
|
||||
.lock()
|
||||
.map_err(|_| anyhow::anyhow!("UI session poisoned"))?
|
||||
.layout_names
|
||||
.clear();
|
||||
let frame = {
|
||||
let mut state = self
|
||||
.session
|
||||
@@ -2893,10 +2894,7 @@ impl UiBridge {
|
||||
frame.tabs = tabs;
|
||||
frame.window = window;
|
||||
// Capture versions before lifecycle hooks can change a dependency.
|
||||
let reads = reads
|
||||
.into_iter()
|
||||
.map(|object| vm.change_version(object).map(|version| (object, version)))
|
||||
.collect::<Result<std::collections::BTreeMap<_, _>, _>>()?;
|
||||
let (reads, names) = crate::presentation::split_reads(reads);
|
||||
frame.focus = match vm.get_attr(desktop, "focus") {
|
||||
Ok(Value::Number(id)) => id.as_i64().and_then(|n| u64::try_from(n).ok()),
|
||||
_ => None,
|
||||
@@ -2913,6 +2911,7 @@ impl UiBridge {
|
||||
state.layout = layout;
|
||||
state.measure_cache = cache;
|
||||
state.layout_reads = reads;
|
||||
state.layout_names = names;
|
||||
}
|
||||
self.commit_frame(vm, Some(root), &frame)?;
|
||||
if let Some(hooks) = hooks {
|
||||
|
||||
Reference in New Issue
Block a user