perf: validate precise source name dependencies before relayout and repaint
This commit is contained in:
@@ -21,6 +21,8 @@ pub(crate) struct Presentation {
|
||||
pub mounts: crate::mount::MountTable,
|
||||
pub published_version: u64,
|
||||
pub force_frame: bool,
|
||||
pub paint_names: Vec<endor_core::ReadDependency>,
|
||||
pub layout_names: Vec<endor_core::ReadDependency>,
|
||||
pub paint_reads: std::collections::BTreeMap<ObjectRef, u64>,
|
||||
pub dependency_invalidations: usize,
|
||||
pub last_invalid_dependency: String,
|
||||
@@ -54,6 +56,25 @@ impl Presentation {
|
||||
vm.change_version(*object).ok()
|
||||
);
|
||||
}
|
||||
if let Some((phase, dependency)) = self
|
||||
.layout_names
|
||||
.iter()
|
||||
.map(|dependency| ("layout", dependency))
|
||||
.chain(
|
||||
self.paint_names
|
||||
.iter()
|
||||
.map(|dependency| ("paint", dependency)),
|
||||
)
|
||||
.find(|(_, dependency)| !vm.object_store().read_dependency_valid(dependency))
|
||||
{
|
||||
self.force_frame = true;
|
||||
self.dependency_invalidations = self.dependency_invalidations.saturating_add(1);
|
||||
let name = match dependency {
|
||||
endor_core::ReadDependency::Name { name, .. } => name.as_str(),
|
||||
_ => "<dictionary kind>",
|
||||
};
|
||||
self.last_invalid_dependency = format!("{phase} name {}:{name}", dependency.object());
|
||||
}
|
||||
self.render_cache.invalidate(ChangeBatch {
|
||||
changes: changes.changes.clone(),
|
||||
rescan_required: changes.rescan_required,
|
||||
@@ -106,6 +127,8 @@ impl Presentation {
|
||||
mounts: crate::mount::MountTable::default(),
|
||||
published_version: 0,
|
||||
force_frame: false,
|
||||
paint_names: Vec::new(),
|
||||
layout_names: Vec::new(),
|
||||
paint_reads: std::collections::BTreeMap::new(),
|
||||
dependency_invalidations: 0,
|
||||
last_invalid_dependency: String::new(),
|
||||
@@ -174,3 +197,22 @@ mod tests {
|
||||
assert!(vm.upgrade(weak).unwrap().is_none());
|
||||
}
|
||||
}
|
||||
|
||||
pub(crate) fn split_reads(
|
||||
reads: Vec<endor_core::ReadDependency>,
|
||||
) -> (
|
||||
std::collections::BTreeMap<ObjectRef, u64>,
|
||||
Vec<endor_core::ReadDependency>,
|
||||
) {
|
||||
let mut objects = std::collections::BTreeMap::new();
|
||||
let mut names = Vec::new();
|
||||
for dependency in reads {
|
||||
match dependency {
|
||||
endor_core::ReadDependency::Object { object, version } => {
|
||||
objects.insert(object, version);
|
||||
}
|
||||
dependency => names.push(dependency),
|
||||
}
|
||||
}
|
||||
(objects, names)
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user