fix: connect toolbar double clicks to native window zoom
Verify Tessera GUI / verify (push) Failing after 1m33s
Verify Tessera GUI / verify (push) Failing after 1m33s
This commit is contained in:
@@ -201,3 +201,32 @@ selection changes to the clicked tab and idle separators return after leaving.
|
||||
The capture API does not establish frame-accurate 160 ms timing. Offline
|
||||
all-target Clippy, formatting, release bundling and whitespace checks passed;
|
||||
no cargo test, automated smoke script or Docker task was run.
|
||||
|
||||
|
||||
### Native toolbar double-click — 2026-10-25
|
||||
|
||||
The custom row previously called only winit's native window-drag operation;
|
||||
a manual double-click in its empty area did not resize the window. The same
|
||||
empty-area hit test now consults AppKit's current NSEvent clickCount before
|
||||
starting a drag. On the second press it calls NSWindow.performZoom, preserving
|
||||
AppKit's standard/user frame toggle and avoiding a hand-built resize animation.
|
||||
Tabs, close buttons and + remain excluded from this handler.
|
||||
|
||||
The adapter reads AppleActionOnDoubleClick without changing system preferences:
|
||||
Minimize calls performMiniaturize; absent/Maximize calls performZoom; disabled
|
||||
or unknown values do nothing. Fill also uses the public performZoom action,
|
||||
whose standard frame fills this application's available screen in the checked
|
||||
configuration. It does not invoke the private _zoomFill selector used by Chrome.
|
||||
Consequently Fill is not claimed to reproduce every macOS tiling margin rule.
|
||||
Native fullscreen uses a different window state and is left to AppKit.
|
||||
|
||||
References: Apple's [performZoom](https://developer.apple.com/documentation/appkit/nswindow/performzoom(_:))
|
||||
and Chromium's [custom draggable-area handling](https://github.com/chromium/chromium/blob/main/components/remote_cocoa/app_shim/native_widget_mac_nswindow.mm).
|
||||
|
||||
Manual native verification: an empty-row double-click changed the Retina window
|
||||
from 2560×1600 to 3024×1888; a second double-click restored 2560×1600. Clicking
|
||||
+ and double-clicking a tab did not zoom the window. Dragging empty toolbar
|
||||
space continued to move the window. The user's double-click preference was
|
||||
absent (default zoom); other preference branches were not changed or manually
|
||||
tested. Offline all-target Clippy, formatting, release bundling and whitespace
|
||||
checks passed. No cargo test or automated smoke script was run.
|
||||
|
||||
Reference in New Issue
Block a user