feat: protect existing objects during read-only calls and track reads
This commit is contained in:
@@ -94,3 +94,61 @@ fn standalone_function_factories_validate_and_own_shared_executable_data() {
|
||||
store.release(second).unwrap();
|
||||
assert_eq!(store.object_count(), 0);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn read_only_scopes_block_existing_container_and_type_writes_but_allow_fresh_results() {
|
||||
let mut store = objects::ObjectStore::new().unwrap();
|
||||
let roots = store.bootstrap_types().unwrap();
|
||||
let record = store.new_object().unwrap();
|
||||
let dict = store.new_dict().unwrap();
|
||||
let cell = store
|
||||
.new_cell(Some(objects::Value::Number(1_i64.into())))
|
||||
.unwrap();
|
||||
let scope = store.begin_read_only();
|
||||
assert!(
|
||||
store
|
||||
.set_attr(record, "value", objects::Value::Nil)
|
||||
.is_err()
|
||||
);
|
||||
assert!(store.attach_type(record, roots.object).is_err());
|
||||
assert!(
|
||||
store
|
||||
.dict_set(
|
||||
dict,
|
||||
objects::Value::Text("key".into()),
|
||||
objects::Value::Nil
|
||||
)
|
||||
.is_err()
|
||||
);
|
||||
assert!(
|
||||
store
|
||||
.cell_set(cell, objects::Value::Number(2_i64.into()))
|
||||
.is_err()
|
||||
);
|
||||
assert_eq!(
|
||||
store.cell_get(cell).unwrap(),
|
||||
objects::Value::Number(1_i64.into())
|
||||
);
|
||||
let fresh = store.new_object().unwrap();
|
||||
store.set_attr(fresh, "value", objects::Value::Nil).unwrap();
|
||||
let nested = store.begin_read_only();
|
||||
assert!(
|
||||
store
|
||||
.set_attr(fresh, "value", objects::Value::Bool(true))
|
||||
.is_err()
|
||||
);
|
||||
store.end_read_only(nested).unwrap();
|
||||
store
|
||||
.set_attr(fresh, "value", objects::Value::Bool(true))
|
||||
.unwrap();
|
||||
let reads = store.end_read_only(scope).unwrap();
|
||||
assert!(reads.contains(&cell));
|
||||
store
|
||||
.set_attr(record, "value", objects::Value::Nil)
|
||||
.unwrap();
|
||||
for object in [record, dict, cell, fresh, roots.object, roots.type_type] {
|
||||
store.release(object).unwrap();
|
||||
}
|
||||
store.collect_cycles();
|
||||
assert_eq!(store.object_count(), 0);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user