feat: protect existing objects during read-only calls and track reads
This commit is contained in:
@@ -148,3 +148,77 @@ fn notification_overflow_requires_rescan_instead_of_losing_changes_silently() {
|
||||
assert_eq!(vm.take_changes().changes.len(), 1);
|
||||
vm.release(object).unwrap();
|
||||
}
|
||||
|
||||
#[derive(Debug)]
|
||||
struct ReadResult {
|
||||
source: ObjectRef,
|
||||
mutate: bool,
|
||||
}
|
||||
impl NativeCallable for ReadResult {
|
||||
fn invoke(&self, cx: &mut NativeContext<'_>, _: &[Value]) -> Result<NativeResult, VmError> {
|
||||
let value = cx.store().get_attr(self.source, "value")?;
|
||||
if self.mutate {
|
||||
cx.set_attr(self.source, "value", Value::Number(99_i64.into()))?;
|
||||
}
|
||||
let result = cx.new_object()?;
|
||||
cx.set_attr(result, "copied", value)?;
|
||||
Ok(NativeResult::Return(Value::Object(result)))
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn read_only_calls_track_borrowed_dependencies_allow_results_and_restore_after_error() {
|
||||
let mut vm = Vm::new().unwrap();
|
||||
let source = vm.new_object().unwrap();
|
||||
vm.set_attr(source, "value", Value::Number(7_i64.into()))
|
||||
.unwrap();
|
||||
let function = vm
|
||||
.allocate(ContextNativeFunction::new(
|
||||
"read result",
|
||||
ReadResult {
|
||||
source,
|
||||
mutate: false,
|
||||
},
|
||||
vec![source],
|
||||
))
|
||||
.unwrap();
|
||||
vm.take_changes();
|
||||
let (value, reads) = vm
|
||||
.call_read_only_with_limits(function, &[], ExecutionLimits::default())
|
||||
.unwrap();
|
||||
assert!(reads.contains(&source));
|
||||
assert!(vm.take_changes().changes.is_empty());
|
||||
let Value::Object(result) = value else {
|
||||
panic!("result")
|
||||
};
|
||||
assert_eq!(
|
||||
vm.get_attr(result, "copied").unwrap(),
|
||||
Value::Number(7_i64.into())
|
||||
);
|
||||
vm.release(result).unwrap();
|
||||
vm.replace_payload(
|
||||
function,
|
||||
ContextNativeFunction::new(
|
||||
"illegal write",
|
||||
ReadResult {
|
||||
source,
|
||||
mutate: true,
|
||||
},
|
||||
vec![source],
|
||||
),
|
||||
)
|
||||
.unwrap();
|
||||
assert!(
|
||||
vm.call_read_only_with_limits(function, &[], ExecutionLimits::default())
|
||||
.is_err()
|
||||
);
|
||||
assert_eq!(
|
||||
vm.get_attr(source, "value").unwrap(),
|
||||
Value::Number(7_i64.into())
|
||||
);
|
||||
vm.set_attr(source, "value", Value::Number(8_i64.into()))
|
||||
.unwrap();
|
||||
vm.release(function).unwrap();
|
||||
vm.release(source).unwrap();
|
||||
assert_eq!(vm.object_count(), 0);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user