feat(canvas): gate legacy editing and hand off explicit migration safely
This commit is contained in:
@@ -15,7 +15,7 @@ the complete Draft acceptance matrix, main integration or production deployment.
|
||||
- Existing `ces-control` runner executes Go checks/build, schema migration and
|
||||
isolated PostgreSQL integration, then the pinned Node 24 consumer and HTTP smoke
|
||||
checks. No local backend build or Docker execution was used.
|
||||
- Local frontend: 797 Node tests and full TypeScript checking passed. Tests use
|
||||
- Local frontend: 800 Node tests and full TypeScript checking passed. Tests use
|
||||
the source modules; packaged SDK and application delivery remain separate gates.
|
||||
|
||||
## What the checks actually prove
|
||||
@@ -31,6 +31,7 @@ the complete Draft acceptance matrix, main integration or production deployment.
|
||||
| AI execution identity and controls | `TestCanonicalAIAdmissionAndLifecycle` covers admission/query/retry, zero-effect rejection, old incarnation callbacks, cancellation, managed image output, owner relocation, archived admission routes and execution after permission revocation. |
|
||||
| Actual frontend RunPort | `tests/headless/foundry-ai.integration.mjs` exercises `createFoundryRuns`, the HTTP transport and ProjectEngine: successful admission response loss/reopen/query, queued cancellation response loss, generation-time content conflict, explicit apply response loss plus undo/reopen/redo, generated image metadata/original bytes/preview, and copy without a new run or upload. |
|
||||
| Host identity migration coordination | `canvas-migration.ts` now drives the real consumer's initial migration: the server commits, the response is lost, a new coordinator reads the stored body/key and queries the original receipt without a second POST. A later intentional raw POST still checks backend idempotent retry. The coordinator's drain and lock ports are fixtures here; this does not prove the old editor's browser handoff gate is connected. |
|
||||
| Browser legacy handoff | `renderer.integration.mjs --migration-only` exercises the actual GraphPage, legacy editor, upgrade panel and Next proxy with native Chrome input, localStorage and Web Locks. Dirty old PATCH ACK precedes migration; another editable view excludes migration; committed response loss survives reload without a second migration POST; uncommitted response loss reuses the original body/key, with terminal rejection followed by explicit fresh preparation; a different cached draft must be explicitly restored before migration. A draft modal cannot block receipt recovery; it becomes actionable after terminal rejection. The upstream is a protocol fixture, not the real Foundry service. |
|
||||
|
||||
The CI #1174 consumer report contains `status: "ok"`, 72 HTTP transport calls,
|
||||
all 14 prior document/resource flags true, plus `runtimeAI`, `aiLostAdmission`,
|
||||
@@ -72,10 +73,27 @@ The recovery store is an in-memory durable-batch fixture, and response loss is
|
||||
injected after successful HTTP responses. Real IndexedDB/Web Locks/browser
|
||||
acceptance is recorded separately in `STEP4_ACCEPTANCE.md`; this service run does
|
||||
not combine every browser crash window with every server operation.
|
||||
The migration coordinator uses an injected string-storage port before a canonical
|
||||
engine exists. The browser still needs its legacy editing freeze/drain, actual
|
||||
storage and workspace lock wiring, reload handling and upgrade UI. Stage 6 is not
|
||||
complete merely because the coordinator's ports pass unit and service tests.
|
||||
The migration coordinator uses a string-storage port before a canonical engine
|
||||
exists. `browser-canvas-migration.ts` supplies localStorage, identity fences and
|
||||
workspace-scoped native Web Locks. Every editable legacy view holds a shared
|
||||
lease; upgrade first freezes and drains its writer, releases that lease, then
|
||||
takes the exclusive lease and prepares again before creating a request. Pending
|
||||
records block affected legacy views across reload. Unknown results retain the
|
||||
original request; only a verified terminal rejection permits fresh preparation.
|
||||
Upload/import/member-task and draft-recovery gates preserve the old editor's
|
||||
content rather than converting in-memory work silently. A differing cached draft
|
||||
is surfaced for explicit recovery, and the current draft is backed up before
|
||||
waiting for its PATCH ACK. The account fence also covers old snapshot requests.
|
||||
|
||||
The browser fixture above proves the connected UI path, including actual native
|
||||
locking, and the separate real-service consumer proves server coordination.
|
||||
They do not combine a real browser and real PostgreSQL in one scenario. Full
|
||||
webpack and Turbopack application regressions each passed 51 checks; the migration
|
||||
entry adds five scenarios and three lock-lifetime unit tests. Unknown
|
||||
receipt/error states remain read-only with an export action. Unsupported Web
|
||||
Locks prevents upgrading, while existing legacy editing remains available when
|
||||
there is no pending migration. Stage 6 and the final requirement matrix still
|
||||
require their delivery audit; passing these checks alone does not complete them.
|
||||
|
||||
`canvas_headless_worker_integration_test.go` supplies deterministic generation
|
||||
output over the actual worker HTTP protocol. Admission, claim, events, canonical
|
||||
|
||||
Reference in New Issue
Block a user