Share scoped display leases and retain incremental resource views
This commit is contained in:
@@ -326,6 +326,59 @@ test('a display pins before its asynchronous read and resets retirement; releasi
|
||||
}finally{gate.resolve();await engine.close();}
|
||||
});
|
||||
|
||||
test('shared display reads and URLs retain byte protection until the last independent reader releases', async () => {
|
||||
const f = fixture(), engine = await f.open({ historyLimit: 1 }), ref = addImage(engine), gate = deferred(), entered = deferred();
|
||||
const read = f.storage.readFile, createURL = URL.createObjectURL, revokeURL = URL.revokeObjectURL;
|
||||
let reads = 0, created = 0, revoked = 0;
|
||||
try {
|
||||
await engine.settle(); await unreferenceImage(engine);
|
||||
f.storage.readFile = async (...args) => { reads++; entered.resolve(); await gate.promise; return read(...args); };
|
||||
URL.createObjectURL = bytes => { created++; return createURL(bytes); }; URL.revokeObjectURL = url => { revoked++; return revokeURL(url); };
|
||||
const cancel = new AbortController(), first = engine.displayResource(ref.id, { signal: cancel.signal }), second = engine.displayResource(ref.id);
|
||||
await entered.promise; assert.equal(reads, 1);
|
||||
const cancelled = assert.rejects(first, { code: 'display_aborted' }); cancel.abort(); await cancelled;
|
||||
assert.ok(engine.getResourcePins().pins.get(ref.id).has('display')); assert.deepEqual((await engine.collectResources({ retentionMs: 0 })).purgedIds, []);
|
||||
gate.resolve(); const b = await second, c = await engine.displayResource(ref.id);
|
||||
assert.equal(b.url, c.url); assert.equal(created, 1); assert.equal(reads, 1);
|
||||
b.release(); b.release(); assert.equal(revoked, 0); assert.ok(engine.getResourcePins().pins.get(ref.id).has('display'));
|
||||
c.release(); assert.equal(revoked, 1); assert.equal(engine.getResourcePins().pins.has(ref.id), false);
|
||||
assert.deepEqual((await engine.collectResources({ retentionMs: 0 })).purgedIds, [ref.id]);
|
||||
} finally { gate.resolve(); await engine.close(); URL.createObjectURL = createURL; URL.revokeObjectURL = revokeURL; }
|
||||
});
|
||||
|
||||
test('project close releases a pending display immediately and never creates a URL from a late read', async () => {
|
||||
const f = fixture(), engine = await f.open(), ref = addImage(engine), gate = deferred(), entered = deferred(), read = f.storage.readFile, createURL = URL.createObjectURL;
|
||||
let created = 0;
|
||||
try {
|
||||
await engine.settle(); f.storage.readFile = async (...args) => { entered.resolve(); await gate.promise; return read(...args); }; URL.createObjectURL = bytes => { created++; return createURL(bytes); };
|
||||
const pending = engine.displayResource(ref.id); await entered.promise;
|
||||
const rejected = assert.rejects(pending, { code: 'engine_closing' }); await engine.close(); await rejected;
|
||||
assert.equal(created, 0); gate.resolve(); await new Promise(resolve => setImmediate(resolve)); assert.equal(created, 0);
|
||||
} finally { gate.resolve(); await engine.close(); URL.createObjectURL = createURL; }
|
||||
});
|
||||
|
||||
test('display failures retain their cause and a fresh reader can retry without uploading again', async () => {
|
||||
const f = fixture(), engine = await f.open(), ref = addImage(engine), read = f.storage.readFile;
|
||||
try {
|
||||
await engine.settle(); f.storage.readFile = async () => { throw Object.assign(Error('disk_failed'), { code: 'disk_failed' }); };
|
||||
await assert.rejects(engine.displayResource(ref.id), { code: 'disk_failed' });
|
||||
assert.equal([...engine.getResourcePins().pins.get(ref.id)].includes('display'), false);
|
||||
f.storage.readFile = read; const handle = await engine.displayResource(ref.id); assert.match(handle.url, /^blob:/); handle.release(); assert.equal(f.uploads.length, 1);
|
||||
} finally { await engine.close(); }
|
||||
});
|
||||
|
||||
test('identity retirement fences new readers and discards a pending local read before creating its URL', async () => {
|
||||
const f = fixture(); let current = true;
|
||||
const engine = await f.open({ isCurrentIdentity: () => current }), ref = addImage(engine), read = f.storage.readFile, gate = deferred(), entered = deferred();
|
||||
const createURL = URL.createObjectURL; let created = 0;
|
||||
try {
|
||||
await engine.settle(); f.storage.readFile = async (...args) => { entered.resolve(); await gate.promise; return read(...args); }; URL.createObjectURL = bytes => { created++; return createURL(bytes); };
|
||||
const pending = engine.displayResource(ref.id); await entered.promise; current = false;
|
||||
await assert.rejects(engine.displayResource(ref.id), { code: 'identity_changed' }); const rejected = assert.rejects(pending, { code: 'identity_changed' }); gate.resolve(); await rejected;
|
||||
assert.equal(created, 0); assert.equal([...engine.getResourcePins().pins.get(ref.id)].includes('display'), false);
|
||||
} finally { gate.resolve(); await engine.close(); URL.createObjectURL = createURL; }
|
||||
});
|
||||
|
||||
test('only recollection of the reserved resource is fenced during deletion; unrelated editing stays available',async()=>{
|
||||
const f=fixture(),engine=await f.open({historyLimit:1}),ref=addImage(engine),gate=deferred(),entered=deferred(),commit=f.storage.commit;try{
|
||||
await engine.settle();await unreferenceImage(engine);f.storage.commit=async(...args)=>{if(args[1].deleteFiles?.length){entered.resolve();await gate.promise;}return commit(...args);};
|
||||
|
||||
Reference in New Issue
Block a user