fix(settings): paper_mode in UserResponse + bot_engine required fields + test sync
schemas.py:
- Add paper_mode: bool = False to UserResponse so frontend can distinguish
paper vs live subscribers and skip HL API key requirement accordingly
api/user.py:
- Return paper_mode=bool(sub.paper_mode) in GET /user/{wallet}
- Fix elif-chain bug in settings validation: two independent `if` blocks
instead of elif so both TP and SL ranges are checked when trump_enabled
- Conditional validation: TP/SL required only when trump_enabled=True;
daily_budget_usd optional at all times
- Persist trump_enabled / macro_enabled from PUT /user/{wallet}/settings
services/bot_engine.py:
- Remove daily_budget_usd from required fields check — it is optional
(null = no cap). Previous code silently skipped ALL trades for users
who cleared their daily budget cap.
alembic/versions/025_module_toggles.py:
- Add trump_enabled, macro_enabled columns to subscriptions table
tests/test_production_readiness.py:
- Sync test_open_positions_requires_signed_wallet_read to patch
verify_signed_request_any (the function now used) instead of
verify_signed_request; update expected call kwargs accordingly
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This commit is contained in:
@@ -135,6 +135,9 @@ class UserSettings(BaseModel):
|
||||
# ISO-8601 UTC strings; both None = always on (Subscription.active still gates it).
|
||||
active_from: Optional[str] = None
|
||||
active_until: Optional[str] = None
|
||||
# Module on/off toggles — default False so new users start with bot idle.
|
||||
trump_enabled: Optional[bool] = None
|
||||
macro_enabled: Optional[bool] = None
|
||||
|
||||
|
||||
class SetSettingsRequest(SignedEnvelope):
|
||||
@@ -147,6 +150,7 @@ class UserResponse(BaseModel):
|
||||
subscribed_at: Optional[str] = None
|
||||
hl_api_key_set: bool
|
||||
hl_api_key_masked: Optional[str] = None
|
||||
paper_mode: bool = False
|
||||
trades: list[BotTrade]
|
||||
settings: UserSettings
|
||||
# Convex-strategy: ISO-UTC timestamp until which the bot is manually armed.
|
||||
|
||||
Reference in New Issue
Block a user